Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename '--ledger-address' to '--node' #1000

Merged
merged 2 commits into from
Jan 16, 2023
Merged

Rename '--ledger-address' to '--node' #1000

merged 2 commits into from
Jan 16, 2023

Conversation

adrianbrink
Copy link
Member

It's more common to refer to the cli option that connects to a fullnode as '--node'.

Created by running git grep -l 'ledger-address' | xargs sed -i '' 's/ledger-address/node/g'

Fixes #864

adrianbrink and others added 2 commits January 11, 2023 09:00
@adrianbrink
Rename '--ledger-address' to '--node'
b83d3dc 
It's more common to refer to the cli option that connects to a fullnode
as '--node'.
@cwgoes
run formatter
3482da7
@cwgoes cwgoes merged commit 7931c02 into main Jan 16, 2023
@cwgoes cwgoes deleted the adrian/rename_ledgeraddress_to_node branch January 16, 2023 13:05
@tzemanovic tzemanovic added the breaking:cli command line breaking change label Jan 16, 2023
juped added a commit that referenced this pull request Jan 16, 2023
@juped
Revert "Merge pull request #1000 from anoma/adrian/rename_ledgeraddre…
1b586f3 
…ss_to_node"

This reverts commit 7931c02, reversing
changes made to 8e2349f.
@juped juped restored the adrian/rename_ledgeraddress_to_node branch January 16, 2023 14:11
@juped juped mentioned this pull request Jan 16, 2023
Merged
bengtlofgren pushed a commit that referenced this pull request May 11, 2023
@juped @bengtlofgren
Revert "Merge pull request #1000 from anoma/adrian/rename_ledgeraddre…
37e1d37 
…ss_to_node"

This reverts commit 7931c02, reversing
changes made to 8e2349f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

Assignees
No one assigned
Labels
breaking:cli command line breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename --ledger-address to --node
3 participants
@adrianbrink @cwgoes @tzemanovic